Removing Race Condition

[cbraynor]

Attempting to remove the race condition whereby a single job can claim more than one item while the transactions are being processed

@mattse can we test this with your example, and if it works merge it in

[m-tse]

@drtriumph I think the race condition is still there for when no job is defined, but it seems fixed for when there is a job defined.

To repro:

• Create a queue, don't pass in any options hash so it uses defaults. Have the worker call resolve({'hello':'world'}) instantly as its work function.
• Place 3(bug manifests with 3+ items) items onto the queue subtree without any _state variable so they should get picked up once the queue worker turns on
• turn on a queue worker. The worker will quickly pick up all 3 items, complete 2 of them, and 1 of them will time out, and revert back to a queue item without a _state variable, yet the queue worker will not attempt to pick this job up even though it is ready

I'm looking into why it's still broken. Let me know if you can't repro it.

[cbraynor]

@mattse I can't seem to reproduce the error. I did do some linting and some minor variable refactoring that included a name change for the processTimeout function that had to become resetItem because it wasn't just used in timeouts anymore - with a corresponding log change. I also fixed a small issue where it wasn't reporting the completion of a job that was removed when it finished

[cbraynor]

Oh, and I removed the need / check for an authenticated reference - it was a legacy from when I used the UID of the access token to specify the job ID

[m-tse]

I was about to bring up "removal of required authenticated reference," but you already did it :) Just another "reduce friction, get running ASAP" point.

LGTM, merging