FirebaseExtended / firebase-queue

MIT License
786 stars 108 forks source link

Configurable tasks and specs paths #40

Closed rafalsobota closed 8 years ago

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


rafalsobota commented 8 years ago

I signed it!

googlebot commented 8 years ago

CLAs look good, thanks!

cbraynor commented 8 years ago

Thanks for the PR. I like the idea of being able to specify these values and how this is backwards compatible, but the JSDoc comments, README documentation, and tests all need updating before I can consider merging this PR.

Also check out my couple of nit-pick comments.

rafalsobota commented 8 years ago

Thanks for the response. Something else should be improved?