search

FirebaseExtended / firebase-queue

MIT License
786 stars 108 forks source link

Give access to task ID to the worker #52

Closed pdesgarets closed 8 years ago

pdesgarets commented 8 years ago

This short PR aims at providing the worker with the task ID. It could be used to set new data with the same id but at a different location (sort of 'process & move' feature).

cbraynor commented 8 years ago

I like this. Initially I was worried anything like this would encourage the worker to modify the task directly, which, if not guarded by a transaction checking ownership, could cause some weird race-condition edge-cases. However, putting it behind the sanitize flag makes it available without making it the default or the responsibility of the publisher to add.

pdesgarets commented 8 years ago

Thanks for being so quick for the merge. Do you know when will be the next release ?

cbraynor commented 8 years ago

I have a couple of other PRs I think it would be nice to merge too, so maybe the next day or two

cbraynor commented 8 years ago

Sorry for the delay - was waiting on a Firebase client release. 1.3.0 is now in npm