FirebaseExtended / firebase-queue

MIT License
786 stars 108 forks source link

Possible bug in QueueWorker.prototype._reject #56

Closed meticoeus closed 8 years ago

meticoeus commented 8 years ago

QueueWorker.prototype._reject creates a function that takes a parameter "error". The transaction complete handler masks "error" with its own "error" which is passed to the recursive attempt upon failure.

I would expect the behavior to keep trying to log the original error instead of the failed transaction attempt.

Is this intended or just a bug?

cbraynor commented 8 years ago

nope, that's a bug. I'll upgrade the repo to use eslint which would have caught this, thanks for pointing it out