search

FirebaseExtended / firebase-queue

MIT License
787 stars 108 forks source link

v1.0.0 candidate #6

Closed cbraynor closed 9 years ago

cbraynor commented 9 years ago

Alright @mattse - you asked for it! Here's the fully-tested, tweaked, edge-case safer version for your review

m-tse commented 9 years ago

Okay, the parts that I'm going to look at, look fine. I'm going to begin running this new code against firebase-backups on my local machine, and then move to staging.

cbraynor commented 9 years ago

@mattse I've fixed the edge-case I'd mentioned I was running into, this should be ready for your testing

cbraynor commented 9 years ago

Agreed, I've made the changes but I was also taking the opportunity to update the README on the processing function parameters

cbraynor commented 9 years ago

I think I addressed all your concerns

m-tse commented 9 years ago

LGTM