Update queue_worker.js - Githubissues

FirebaseExtended / firebase-queue

MIT License

786 stars 108 forks source link

Update queue_worker.js #63

Closed keshavsaharia closed 8 years ago

keshavsaharia commented 8 years ago

Updated for new Firebase library (v3.0)

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

keshavsaharia commented 8 years ago

I signed it! Also tests failed because they are probably using v2.3. The only changes were to .key and .ref, maybe something to make them cross-compatible? I have not checked to see if .key() and .ref() still work in v3.0.

googlebot commented 8 years ago

CLAs look good, thanks!

keshavsaharia commented 8 years ago

Used _.isFunction to enable legacy support.

donbarthel commented 8 years ago

I think for Firebase 3.0 support you also have to change all mentions of: Firebase.ServerValue.TIMESTAMP to: Firebase.database.ServerValue.TIMESTAMP

donbarthel commented 8 years ago

Oh, and you'll have to do something about the package.json as well to say that Firebase v3 is OK too.

Your code attempts to be v2 compatible as well as v3. How to say that in package.json? Maybe a better way to go is to make this update v3 compatible only.

cbraynor commented 8 years ago

Thanks for your input both of you, #66 takes into account the comments / ideas here