Closed keshavsaharia closed 8 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I signed it! Also tests failed because they are probably using v2.3. The only changes were to .key and .ref, maybe something to make them cross-compatible? I have not checked to see if .key() and .ref() still work in v3.0.
CLAs look good, thanks!
Used _.isFunction
to enable legacy support.
I think for Firebase 3.0 support you also have to change all mentions of: Firebase.ServerValue.TIMESTAMP to: Firebase.database.ServerValue.TIMESTAMP
Oh, and you'll have to do something about the package.json as well to say that Firebase v3 is OK too.
Your code attempts to be v2 compatible as well as v3. How to say that in package.json? Maybe a better way to go is to make this update v3 compatible only.
Thanks for your input both of you, #66 takes into account the comments / ideas here
Updated for new Firebase library (v3.0)