search

FirebaseExtended / firebase-queue

MIT License
786 stars 108 forks source link

in_progress_state confusion #77

Closed christianalfoni closed 7 years ago

christianalfoni commented 7 years ago

Description

Code sample

Hi there,

Our team was tracking down a bug due to us defining the same in_progress_state name on all our workers. We did not understand what it did, but after a great explanation here: https://github.com/firebase/firebase-queue/issues/76, we suggest to open the docs to be more explicit about how this actually works :)

Thanks for a really amazing project, this has totally saved our startup!

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

cbraynor commented 7 years ago

Hi @christianalfoni, thanks for the pull request. I unfortunately have to insist on the CLA being signed before I can accept even a PR to the docs.

christianalfoni commented 7 years ago

Ah for sure... signed it now :)

googlebot commented 7 years ago

CLAs look good, thanks!

googlebot commented 7 years ago

CLAs look good, thanks!

cbraynor commented 7 years ago

Awesome, thanks for the contribution

christianalfoni commented 7 years ago

Happy to help :)