search

FirebaseExtended / firebase-queue

MIT License
786 stars 108 forks source link

Updating the test suite to use firebase-admin #93

Closed cbraynor closed 7 years ago

cbraynor commented 7 years ago

Fixes #90

NPM (at least v3.10.8) seems to install optional dependencies by default which is not what we want I don't think. I think it's clear from the documentation that you always have to install firebase-queue alongside either firebase-admin or firebase, so let's just remove it from anything other than the devDependencies.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.0004%) to 99.803% when pulling fd3078c7fbb739c48f09ee865849f1f0b6df88b7 on firebase-admin into 06646e07276db2ee64a52fa4231d395c8e8f2a4c on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.0004%) to 99.803% when pulling fd3078c7fbb739c48f09ee865849f1f0b6df88b7 on firebase-admin into 06646e07276db2ee64a52fa4231d395c8e8f2a4c on master.

cbraynor commented 7 years ago

Application default credentials are mentioned in the blog post linked. These docs are mainly for the initial development of a queue where you're unlikely to have such credentials installed.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.0004%) to 99.803% when pulling 4eafd552d25ec631b2f67a3823be9e37d56d5bd9 on firebase-admin into 06646e07276db2ee64a52fa4231d395c8e8f2a4c on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.0004%) to 99.803% when pulling 6cfdf59102d58d7750551c56df35f32cfbfbc59c on firebase-admin into 06646e07276db2ee64a52fa4231d395c8e8f2a4c on master.