FirebaseExtended / firepad

Collaborative Text Editor Powered by Firebase
Other
3.87k stars 884 forks source link

Building on Windows is problematic. #236

Open kofifus opened 8 years ago

kofifus commented 8 years ago

continuing the discussion on https://github.com/firebase/firepad/issues/233

There is a line ending window/unix issue I managed to solve by remarking //value: "unix", //level: "error"

in grunt.initConfig({

As far as I can tell from grunt docs these should not usually be there.

  1. Michael can you pls check on your side this still build for you ? Can I commit this change in a PR ?

With this change I got firepad.js to build. However I still get further grunt errors:

D:\SourceTree\firepad>grunt Running "coffeelint:app" (coffeelint) task

1 file lint free.

Running "coffee:compile" (coffee) task File lib/ace-adapter.js created.

Running "concat:firepadjs" (concat) task File "dist/firepad.js" created.

Running "uglify:firepad-min-js" (uglify) task File "dist/firepad.min.js" created.

Running "copy:toBuild" (copy) task Copied 2 files

Running "karma:unit" (karma) task WARN [reporter]: Can not load "spec", it is not registered! Perhaps you are missing some plugin? WARN [reporter]: Can not load "failed", it is not registered! Perhaps you are missing some plugin? WARN [reporter]: Can not load "coverage", it is not registered! Perhaps you are missing some plugin? WARN [watcher]: Pattern "D:/SourceTree/firepad/bower_components/codemirror/lib/codemirror.js" does not match any file. WARN [watcher]: Pattern "D:/SourceTree/firepad/bower_components/firebase/firebase.js" does not match any file. WARN [preprocess]: Can not load "coverage", it is not registered! Perhaps you are missing some plugin? WARN [karma]: Port 9876 in use INFO [karma]: Karma v0.12.37 server started at http://localhost:9877/ WARN [launcher]: Can not load "PhantomJS", it is not registered! Perhaps you are missing some plugin?

after which it just hangs there and I need to break it.

  1. Any help with this ?

Thx!

mikelehen commented 8 years ago

Did you run "bower install"? That might explain the WARNs about bower_components...

If you ran "grunt watch" it's actually supposed to "hang." It will build firepad and then re-build it whenever any of the source files change. You can just do "grunt" to build and run the tests once.

Unfortunately I'm not sure why you're hitting these errors. I'm guessing it's related to running on Windows (I and other contributors have been on mac I think). :-/ I'd rather not remove the linter warning about line-endings.

kofifus commented 8 years ago

I just typed grunt and pressed enter

it would be good when you have time to help with this so that windows developers can contribute as well without build difficulties. At least grunt builds firepad.js so I can proceed ...

cheers

mikelehen commented 8 years ago

Does "grunt build" complete? If so, then I'm guessing "grunt" is hanging while trying to run tests. :-/

kofifus commented 8 years ago

yeah 'grunt build' completes fine.