Don't clear CodeMirror inline styles on setText

krafftsimon commented 3 years ago

Description

Bug fix: Firepad.prototype.setText would overwrite the inline styles of the codemirror wrapper element by calling setAttribute('style', 'display: none') instead of style.display = "none".

Code sample

N/A

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 316823464

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.02%) to 65.569%

Files with Coverage Reduction	New Missed Lines	%
lib/rich-text-codemirror.js	1	53.86%
<!--	Total:	1		-->

Totals
Change from base Build 261384869:	0.02%
Covered Lines:	2311
Relevant Lines:	3377

💛 - Coveralls

samtstern commented 3 years ago

@krafftsimon thank you for this PR! Seems like a good change to me.

samtstern commented 3 years ago

This change was released in version 1.5.11

FirebaseExtended / firepad