Clear tasks when removing listener storage listener

FirebaseExtended / make-it-so-android

Apache License 2.0

214 stars 58 forks source link

Clear tasks when removing listener storage listener #19

Closed mtali closed 1 year ago

mtali commented 1 year ago

There is a subtle bug making tasks map store inconsistent data

Reproduce

Make sure you are not logged in
Create a task
Login to an existing account
Going back to the tasks page, the task created on step two will be there (ViewModel was persisted). Now you won't be to edit it because it is no longer linked to your account.

Why: Logic to update userId during the login process was removed #18

Fix: Clear tasks when removing the storage listener on the tasks ViewModel

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

marinacoelho commented 1 year ago

Hi @mtali thank you for submitting this Pull Request. The main branch was updated today and there are a lot of changes in the new version. This bug should now be fixed!