FirebaseExtended / make-it-so-android

Apache License 2.0
214 stars 58 forks source link

Use hilt parameter support so that viewmodel is only initialized once #38

Closed jonsmirl closed 1 year ago

jonsmirl commented 1 year ago

Please check this. My Firebase account is not set up for this app anymore so I can't test.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

marinacoelho commented 1 year ago

Hi @jonsmirl thanks for submitting the PR! I've tested the code and it works fine. Before we can merge it, can you follow this link to sign the Contributor License Agreement?

jonsmirl commented 1 year ago

The CLA check is passed.

marinacoelho commented 1 year ago

Great. I'll merge the PR, thanks again for your contribution!