search

FirebaseExtended / make-it-so-android

Apache License 2.0
214 stars 58 forks source link

Adding state hoisting in order to have the compose preview available. #5

Closed jgavazzisp closed 2 years ago

jgavazzisp commented 2 years ago

Hi there, thanks for creating the project to nudge the community towards the recommended way to work with Firebase. I just had one suggestion for now which is to do a state hoisting on the screen — I've submitted one example and can do the same for the other ones if you guys are happy with it —.

After doing the state hoisting we can add the preview tag to the screen and enable live edits — when using Android Studio Electric Eel — to have fast feedback on UI changes.

Please feel free to discard the PR if you feel it is not useful.

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.