search

FirebaseExtended / protobuf-rules-gen

This is an experimental protoc plugin that generates Firebase Rules for Cloud Firestore based on Google's Protocol Buffer format. This allows you to easily validate your data in a platform independent manner.
Apache License 2.0
197 stars 13 forks source link

How about the status of this project? #39

Closed kimurayu45z closed 2 years ago

kimurayu45z commented 3 years ago

I want to use this library with latest development environment. Furthermore, I want to use in Ubuntu but the compiled binary is only for mac os x86 x64 but because of deprecated bazel configuratinos, I can't build from the source code.

So I want to hear about the status of this project. Source codes written in C++ seems to work even now so plz update the bazel configurations. ( And migrate to protobuf3 completely)

var-const commented 3 years ago

Thank you for filing the issue. The repository is being maintained on a best-effort basis -- we prioritize other projects at the moment, but we are always open to reviewing contributions.

I have reproed this on a Linux machine and can confirm that Linux build is currently broken and Bazel configuration needs to be updated. If you're interested in working on a fix for this, we would gladly review it. Otherwise, I can take a look at this sometime later this month.

kimurayu45z commented 3 years ago

Thank you very much. I'll wait for later this month. In addition, I would appreciate if the binary for linux_amd64 is distributed because making a build environment with Bazel in Docker is bothersome.

Thanks.

shrek-kurata commented 3 years ago

Hope the release can happen.

kimurayu45z commented 2 years ago

https://github.com/FirebaseExtended/protobuf-rules-gen/pull/43 This PR was merged. Thank you very much.

@var-const Could you please create a "release"?

var-const commented 2 years ago

@KimuraYu45z I will work on a release tomorrow. Thank you again for the patch.

var-const commented 2 years ago

@KimuraYu45z I have prepared release v0.2.3.

kimurayu45z commented 2 years ago

@var-const Thank you! LGTM! I think it is ok to be not "pre" release.

var-const commented 2 years ago

@KimuraYu45z The previous owner of the repo marked each release as "pre-release", probably to highlight that this is a "best effort" product. I'm just following his approach on this.

kimurayu45z commented 2 years ago

@var-const Thanks, I see.

https://github.com/FirebaseExtended/protobuf-rules-gen/blob/master/.github/workflows/binary.yml#L6

I wrote the trigger of github actions workflow as release created but it will not be emitted when pre-release is created.

I need to change it to release published which will be emitted when also pre-release.

var-const commented 2 years ago

I need to change it to release published which will be emitted when also pre-release. Sounds good.

kimurayu45z commented 2 years ago

@var-const https://github.com/FirebaseExtended/protobuf-rules-gen/pull/44/files I made the PR. I would appreciate if you review it. Thanks

var-const commented 2 years ago

Merged, thanks!