FirebaseExtended / reactfire

Hooks, Context Providers, and Components that make it easy to interact with Firebase.
https://firebaseopensource.com/projects/firebaseextended/reactfire/
MIT License
3.52k stars 401 forks source link

useAnalytics missing in ReactFire v4 #429 #431

Closed shiiinji closed 3 years ago

shiiinji commented 3 years ago

Description

useAnalytics missing in ReactFire v4

Code sample

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

shiiinji commented 3 years ago

@googlebot I signed it!

shiiinji commented 3 years ago

Thank you @shiiinji! I've left a few comments, but once they're resolved I'd be happy to merge this.

I appreciate your great feedbacks. I resolved the issues.

jhuleatt commented 3 years ago

One more change - can you please run yarn docs at the root of the repository? That will auto-generate reference docs for the new features you've added.

shiiinji commented 3 years ago

One more change - can you please run yarn docs at the root of the repository? That will auto-generate reference docs for the new features you've added.

I run yarn docs and commited the auto-generate reference docs by #d000464.

jhuleatt commented 3 years ago

Thanks again @shiiinji! These changes are available now with

npm install reactfire@exp

# OR

yarn add reactfire@exp

And will be included in an upcoming release!

shiiinji commented 3 years ago

Thank your great feedbacks.