FirebaseExtended / reactfire

Hooks, Context Providers, and Components that make it easy to interact with Firebase.
https://firebaseopensource.com/projects/firebaseextended/reactfire/
MIT License
3.52k stars 401 forks source link

Add support for AppCheck, Analytics, and Functions sdks. #432

Closed justjish closed 3 years ago

justjish commented 3 years ago

Description

Code Cleanup

Code sample

[TODO]

jhuleatt commented 3 years ago

Hi @sujishpatel thank you for your contribution! We really appreciate all of this work, but it is difficult for us to review a PR with so many different changes. Would you be up for breaking this apart into a few PRs and issues? My suggestion for breaking this into pieces is:

Individual PRs

Please file an issue for discussion

Other

Thank you again for your hard work! If you can break your changes out into multiple PRs, we'll get them reviewed and merged as quickly as possible.

justjish commented 3 years ago

will do