Closed justjish closed 3 years ago
Hi @sujishpatel thank you for your contribution! We really appreciate all of this work, but it is difficult for us to review a PR with so many different changes. Would you be up for breaking this apart into a few PRs and issues? My suggestion for breaking this into pieces is:
[api].sdk.app.name
for all app name checksobjectVal
from rxfire for database: this was fixed here, so I don't think it is needed any moreThank you again for your hard work! If you can break your changes out into multiple PRs, we'll get them reviewed and merged as quickly as possible.
will do
Description
useInitAppCheck
useAppCheck
AppCheckProvider
useInitAnalytics
useAnalytics
AnalyticsProvider
useInitFunctions
useFunctions
FunctionsProvider
dist
folder to exist in repo to allow users to useyarn add http://github.com/.../reactfire#[branch]
... todo produce build during pre-commit check?Code Cleanup
getValue, getString, getBoolean...
rather than just having duplicate code.objectVal
from rxfire for database//@ts-ignore
to//@ts-expect-error
Code sample
[TODO]