search

FirebaseExtended / reactfire

Hooks, Context Providers, and Components that make it easy to interact with Firebase.
https://firebaseopensource.com/projects/firebaseextended/reactfire/
MIT License
3.52k stars 401 forks source link

Use rxfire/remote-config for remote config getters #434

Closed justjish closed 3 years ago

justjish commented 3 years ago

Description

Code Cleanup: remote-config

  1. Use rxfire/remote-config for remote config getters. The getValue.tsx is simply a copy from rxfire/remote-config anyway.
  2. Use the public api for getting the app name for remote config rather than a private variable.
  3. Remove @param remoteConfig Optional instance. If not provided ReactFire will either grab the default instance or lazy load. from all comments.

Code sample

N/A - Functionality remains same.

jhuleatt commented 3 years ago

Thank you @sujishpatel!