search

FirebaseExtended / reactfire

Hooks, Context Providers, and Components that make it easy to interact with Firebase.
https://firebaseopensource.com/projects/firebaseextended/reactfire/
MIT License
3.52k stars 401 forks source link

Resolve or Replace @ts-ignore #435

Closed justjish closed 3 years ago

justjish commented 3 years ago

Description

  1. Reordered error checking for SdkProvider so that it will actually throw error for no sdk provided.
  2. Resolve @ts-ignore in SdkProvider: v9 exposes props.sdk.app.name for all SDKs, so used that for app name comparison.
  3. For the remaining ts-ignores, replaced with @ts-expect-error.

Code sample

jhuleatt commented 3 years ago

Thanks for this cleanup @sujishpatel! Can you please run yarn docs from the root of the project to make that last check go green?

(Sorry that wasn't clear. I've updated the contributing guide to make it easier for future contributors).

jhuleatt commented 3 years ago

Thank you @sujishpatel!