FirebaseExtended / reactfire

Hooks, Context Providers, and Components that make it easy to interact with Firebase.
https://firebaseopensource.com/projects/firebaseextended/reactfire/
MIT License
3.52k stars 401 forks source link

Fix reconciler : Expose the contexts #486

Closed RenaudRohlinger closed 2 years ago

RenaudRohlinger commented 2 years ago

Hello!

Description

To consume the contexts with react reconciler you need to forward the contexts using a "bridge". See https://github.com/facebook/react/issues/17275 Exposing each context is then necessary if we don't want to wrap all our components twice in that case.

google-cla[bot] commented 2 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

RenaudRohlinger commented 2 years ago

@googlebot I signed it!

jhuleatt commented 2 years ago

Hi @RenaudRohlinger, thanks for the PR! While this seems like a rare use case (react-reconciler is "Use it at your own risk" according to the React docs), I think it should be fine to merge if it will benefit you.

jhuleatt commented 2 years ago

This is available in ReactFire 4.2.1

RenaudRohlinger commented 2 years ago

Thanks!