search

FirebaseExtended / reactfire

Hooks, Context Providers, and Components that make it easy to interact with Firebase.
https://firebaseopensource.com/projects/firebaseextended/reactfire/
MIT License
3.51k stars 399 forks source link

updating docs from 'useSignInCheck' to 'useSigninCheck' #505

Closed thomasmburke closed 2 years ago

thomasmburke commented 2 years ago

Ran into import errors when following the docs because of this subtle lowercase i.

I think overall it would be worth having this camel case exception be consistent with signInCheckResult, but not worth introducing a breaking change in my opinion, so just looking to update the docs and references in this repo.

jhuleatt commented 2 years ago

Thanks @thomasmburke!

jhuleatt commented 2 years ago

fixed in this commit: https://github.com/FirebaseExtended/reactfire/commit/414201e88bd6f6701998993f6203e4d49773147b

thomasmburke commented 2 years ago

Sorry for missing this!