Closed CapsAdmin closed 1 year ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
I've signed the agreement now.
As a silly workaround in the meantime to disable suspense I can wrap <FirebaseAppProvider firebaseApp={app} suspense={false}>{...}</FirebaseAppProvider>
around the component that uses useSigninCheck, use the status field and then enable suspense again when successful in its child components.
A very belated thank you, @CapsAdmin!
Description
While trying to debug while useSigninCheck suspends indefinitely on latest version and master, I tried to disable suspense but this was not working. Having cloned the repo locally and debugged I noticed that the options used in useSigninCheck was never passed to useObservable which takes the options object.