search

FirebirdSQL / NETProvider

Firebird ADO.NET Data Provider
https://www.firebirdsql.org/en/net-provider/
Other
161 stars 66 forks source link

reading the Unicode parameter defined in the Code First mapping #1045

Closed gilsonjoanelo closed 2 years ago

gilsonjoanelo commented 2 years ago

First, I'm using Google Translate.

I am creating this PR as directed through Twitter.

I made a small change in the src/FirebirdSql.EntityFrameworkCore.Firebird/Storage/Internal/FbTypeMappingSource.cs class to detect if the code is not setting the unicode attribute, as well as I changed the src/FirebirdSql.EntityFrameworkCore.Firebird/Storage/Internal/ class FbStringTypeMapping.cs to receive the mapping value.

If the Unicode attribute is not found, the code maintains the same pattern as before. In this case the default value = true

I'm making this contribution due to the need to turn off Unicode in the company's bases, with that, I came across this ignored implementation that makes me have to rebuild the provider with each new version.

cincuranet commented 2 years ago

It all looks good to me. I think I need to check VARCHAR constants handling - there might be assumptions about stuff being UTF8.