search

FirebirdSQL / NETProvider

Firebird ADO.NET Data Provider
https://www.firebirdsql.org/en/net-provider/
Other
152 stars 63 forks source link

HasRows should be hidden or throw NotSupportedException #1092

Open Conman-123 opened 1 year ago

Conman-123 commented 1 year ago

According to https://github.com/FirebirdSQL/NETProvider/issues/317, HasRows always returns true as it is not supported by Firebird. However, this is not documented anywhere and is causing "There are no data to read" exceptions because it always returns true.

It would be very helpful to hide this property, or throw NotSupportedException, or change it to always return false with a docstring explaining that it is not supported by Firebird.

Obviously this would be a big breaking change.

cincuranet commented 1 year ago

It's unfortunate situation. Although the change to NotSupportedException is trivial, I'd like to hear more opinions whether such breaking change is worth it. I personally don't have strong feeling about one or the other.