Optimization Fetch() and FetchAsync()

[BFuerchau]

Advantage

• less object creation in fetch
• less GC activities In previous version for each row are n times DbValue-objects created for each row. Now it will create only the object[] array to store raw values. When the fetch is done, the object[] is copied to the single DbValue[] array. The reader gets every time the same row with the new values. The object[] array must be destroyed from each row, as DbValue[] array previous. At the end only n DbValue objects must destroyed. In case of 100, thousends or more rows you save time with creation and GC which can make until 10% or more of performance.

[BFuerchau]

I hope i didn't have transmission errors. It seams i can't create a separate pull request for the FbDataReader. Can you help once more?

[cincuranet]

This PR is having unrelated changes in FbDataReader from other PR.

[BFuerchau]

I have recognnized, that the call needs really time. Without inlining the speed goes a little bit down.

[cincuranet]

But did you consider other effects of inlining? The JIT is doing great job 99% of the time with its heuristics on general code. I can make numbers nice in (micro)benchmarks, but that doesn't mean the benefit will be there for real-world scenario.

[BFuerchau]

I can't manage to put the 2 changes of GdsStatement version 10 and 13 in exactly 1 commit, since version 13 has to make an override.

[cincuranet]

Multiple commits into GdsStatements is fine. I'm talking about changes in FbDataReader.

[BFuerchau]

I test with 1000 and more rows per result. What's the harm if the inlining is active;-)?

Ok, but how can i make the FbDataReader a separate request? Should i fork the project a second time only for the reader?

[cincuranet]

What's the harm if the inlining is active;-)?

https://en.wikipedia.org/wiki/Inline_expansion

Ok, but how can i make the FbDataReader a separate request?

Use different branch.

[BFuerchau]

I have tried a different branch, but the 2 commits from GdsStatements are than also included. I didn't know how to do this, as you can see this is a second try.

I'm just overwhelmed. So far I've only worked with a local git with a single branch and multiple changes are packed into one commit. I just don't know what to do. Is it perhaps better to do a separate fork with exactly this 1 change?

[fdcastel]

Is it perhaps better to do a separate fork with exactly this 1 change?

Yes. This is the best practice, @BFuerchau.

From latest master, create one branch for each of your (independent) changes. Then push each of them and submit a different PR.

Coming late to the party, but I presume this is what @cincuranet is asking you to do.

[fdcastel]

So far I've only worked with a local git with a single branch and multiple changes are packed into one commit.

Tip: You are losing a lot of what git could offer you.

Make smaller changes, commit often. Use branches like hell. They are extremely light in git (unlike other-revision-control-systems-of-the-past-who-must-not-be-named).

Also a good git client may help you.

And Beyond Compare. I simply cannot work without it. Best 70 USD I already spent in my life.

[BFuerchau]

Thank you for your tips. I'm a single developer with only a few small projects. We have a gitlab server, but i don't like the overhead. I'm using git only as additional source save;-).

So for the requests i will try it for a last time. If it also don't work i have no idea to do so. I can than only upload the my changes for 3 sourcefiles and may be another one will take this changes. For me, i can live with my own version of netprovider;-) to load fast resultsets.

[BFuerchau]

I will try it the last time with a new request.