search

FirebirdSQL / NETProvider

Firebird ADO.NET Data Provider
https://firebirdsql.org/en/net-provider/
Other
161 stars 66 forks source link

Creation of backup and restore statistics can be switched off #1182

Closed DevM900 closed 4 months ago

DevM900 commented 4 months ago

By setting the new property FbBackup.IncludeStatistics to falsefixes #1180. To ensure backward compatibility, the default value of the FbBackup.IncludeStatistics property is true.

cincuranet commented 4 months ago

I'm wondering whether instead of introducing new property making Statistics nullable would do the same job...

DevM900 commented 4 months ago

My initial intention was not to change any existing property. But I think making the Statistics property nullable is also fine. When I think about the users of the class, however, I can't judge which is the better solution.

DevM900 commented 4 months ago

If you prefer nullable, I'd change that.

cincuranet commented 4 months ago

Yeah, I would go with nullable. Unless it blows in some unexpected way, it seems better to me.

DevM900 commented 4 months ago

Done.