search

FirebirdSQL / firebird

Firebird server, client and tools
https://www.firebirdsql.org/
1.23k stars 213 forks source link

Never use spaces in service short name [CORE3648] #3999

Open firebird-automations opened 12 years ago

firebird-automations commented 12 years ago

Submitted by: Thijs van Dien (thijsvandien)

When specifying an instance name to instsvc, it is possible to use spaces. These are then used in several places, including where not appropriate. For example:

instsvc install -auto -superserver -guardian -z -n "My Instance"

results in the services 'FirebirdGuardianMy Instance'/'FirebirdServerMy Instance,' with display names 'Firebird Guardian - My Instance'/'Firebird Server - My Instance.' I suggest to name the services 'FirebirdGuardianMyInstance'/'FirebirdServerMyInstance', and only use the spaces in the display name.

firebird-automations commented 12 years ago

Commented by: @mrotteveel

I don't see why Firebird should be restrictive in this regard. Windows allows services with spaces in their names. On my computer I have the following services with space in their servicename: * AMD External Events Utility * AMD FUEL Service * Steam Client Services

Unless you have a good reason why Firebird should be changed to disallow spaces, I think we should keep it as is.

firebird-automations commented 12 years ago

Commented by: Thijs van Dien (thijsvandien)

Well, it works, but since really most of services avoid spaces (name me any Microsoft Service that does use them), I think it can be considered bad practice.

Nevertheless, 'FirebirdServer' is already used in the short service name (e.g. 'FirebirdServerDefaultInstance'), without spaces, whereas the display name uses 'Firebird Server' (e.g. 'Firebird Server - DefaultInstance'). This indicates that, at some point in history, it was already decided not to use spaces in Firebird's short service name, but this preceded the feature to define a custom instance name. When that feature was introduced, spacing was not taken into account; therefore I suggest to correct this inconsistency. Not by means of prohibiting the use of spaces in general, but by leaving them out of the short service name.