search

FirebirdSQL / firebird

Firebird server, client and tools
https://firebirdsql.org
1.26k stars 217 forks source link

Building with --with-builtin-tommath doesn't work [CORE6061] #6311

Closed firebird-automations closed 5 years ago

firebird-automations commented 5 years ago

Submitted by: Vadim Zeitlin (vz)

Building d2116ea145dceb113e9eb6cfb9b4d232bdaf8583 (T4_0_0_Beta1-106-gd2116ea145) with

./configure --with-builtin-tomcrypt --with-builtin-tommath --without-editline --disable-static

doesn't work because tomcrypt doesn't find tommath headers. A trivial fix would be

---------------------------------- >8 -------------------------------------- diff --git a/extern/libtomcrypt/makefile.shared b/extern/libtomcrypt/makefile.shared index b4e7c43062..e34d0746e1 100644 --- a/extern/libtomcrypt/makefile.shared +++ b/extern/libtomcrypt/makefile.shared @@ -14,7 +14,7 @@

⁠ make -f makefile.shared PREFIX=/opt/libtom install

⁠

-CFLAGS += -DLTC_PTHREAD -DUSE_LTM -DLTM_DESC -pthread +CFLAGS += -DLTC_PTHREAD -DUSE_LTM -DLTM_DESC -pthread -I../libtommath

PLATFORM := $(shell uname | sed -e 's/_.*//')

---------------------------------- >8 --------------------------------------

but this almost surely shouldn't be done unconditionally.

Commits: FirebirdSQL/firebird@a021ed44182800efce3312632d6244cc974718bd

firebird-automations commented 5 years ago
Modified by: @AlexPeshkoff assignee: Alexander Peshkov \[ alexpeshkoff \]
firebird-automations commented 5 years ago
Modified by: @AlexPeshkoff status: Open \[ 1 \] =\> Resolved \[ 5 \] resolution: Fixed \[ 1 \] Fix Version: 4\.0 Beta 2 \[ 10888 \]
firebird-automations commented 5 years ago
Modified by: @pavel-zotov status: Resolved \[ 5 \] =\> Resolved \[ 5 \] QA Status: No test =\> Cannot be tested
firebird-automations commented 5 years ago
Modified by: @pavel-zotov status: Resolved \[ 5 \] =\> Closed \[ 6 \]