search

FirebirdSQL / firebird

Firebird server, client and tools
https://www.firebirdsql.org/
1.19k stars 204 forks source link

Fix for #8101 #8102

Closed aafemt closed 4 days ago

aafemt commented 1 week ago

log message if plugin factory returns nullptr and set no error

Such situation cannot disappear just like that so logging will be endless and log file will overflow. I don't like this idea.

hvlad commented 1 week ago

Buggy plugins should be detected and removed by DBA.

aafemt commented 1 week ago

It is not given that the plugin is buggy. Signalling Plugin Manager to skip it and try the next plugin in list may be a part of its logic. May be it set a warning (which is not checked by check() BTW). There is also no noticeable performance penalty in this case. If plugin is buggy indeed existing DBA will detect it anyway by absence of result. Log overflow in absence of DBA is much more dangerous from my POV.