Function MAKE_DBKEY may produce random errors if used with relation name

FirebirdSQL / firebird

Firebird server, client and tools

https://firebirdsql.org

1.26k stars 217 forks source link

Function MAKE_DBKEY may produce random errors if used with relation name #8203

Closed aafemt closed 3 months ago

aafemt commented 3 months ago

Because function LiteralNode::getText()returns string which is not zero-terminated. Particularly QA test gh_8168_test.py sometimes unexpectedly produces "Malformed string" error.

hvlad commented 3 months ago

Few notes:

it happens in DEBUG build with table names of any length and in RELEASE build with table names greater than 15 bytes. As QA test gh_8168_test uses short table names, it could fail with DEBUG build only
gbak is not affected as it uses table ID's, not names.