FirebirdSQL / php-firebird

Firebird PHP driver
Other
66 stars 15 forks source link

Fix boolean parameters #28

Closed diegosardina closed 2 years ago

diegosardina commented 2 years ago

This should fix #23 where false is converted to an empty string (while true doesn't work).

The code is taken and adapted from PDO Firebird where all types are taken in consideration and converted to its boolean representation (where possible).

The previous code looks wrong and I don't know how it could work to some people (and it seems there is a copy-paste mistake from the above block, although dead code because of the continue statement). Furthermore the bug here was always replicable