FirebirdSQL / php-firebird

Firebird PHP driver
Other
66 stars 15 forks source link

Fix and re-enable tests/bug46543.phpt #43

Open Jon4t4n opened 1 year ago

Jon4t4n commented 1 year ago

tests/bug46543.phpt was disabled if the PHP version is >= 8.0 in PR #39. We might want to fix and re-enable.

The test verifies that we don't leak memory if we call ibase_trans multiple times with invalid arguments. In older PHP versions, the engine emitted a warning so the script would keep running. But, in PHP 8, we get a fatal error and crash at the first call. So, maybe we don't need this test in newer PHP versions because you can't call the function with invalid arguments.

If we decide to keep this test disabled for PHP 8 and newer, please update the skip message in the test before closing this issue.