search

FirebirdSQL / python3-driver

Firebird driver for Python that uses new Firebird API
https://www.firebirdsql.org/en/devel-python-driver/
MIT License
26 stars 10 forks source link

Fix for #34 - Pre-1970 dates causes OverflowError #37

Closed Fred-si closed 4 months ago

Fred-si commented 4 months ago

Hi.

This merge request should fix #34 issue.

With the fix, I have added an assertion to validate the behavior of data insertion, but I was unable to run the tests because I haven't a working Firebird server on my computer.

I have tested the fix with a Python project that uses SQLAlchemy, it works in this context and the test suite has not found any regression.

pcisar commented 4 months ago

Good work, thanks for your contribution.

fdcastel commented 3 months ago

@pcisar Can we get a release with this fix?