Firefly9093 / web-iv-portfolio-site

Web IV Portfolio Sites
0 stars 0 forks source link

Semantics #9

Open zschrunk opened 9 years ago

zschrunk commented 9 years ago

I'm not too sure on some of these things for semantics, but I think (thinking isn't my strong suit) hero's are only used for images that will be behind text. Also with your name and then what you do they are both h2s. Why don't you just put them in the same header link, or make one an h3 for hierarchy. The rest looked alright though.

Satisfactory

elladurham commented 9 years ago

For marking up subtitles refer to http://html5doctor.com/howto-subheadings/ or https://css-tricks.com/how-to-mark-up-subtitles/

I think it's fine to call any large, prominently placed image on a site a 'hero' it's a term that is used in the industry frequently. http://en.wikipedia.org/wiki/Hero_image

I would try to better name the classes you're using to target the images in the hero space though. Without other context they don't have as much meaning—like in your stylesheet for example.