FirefoxBar / xStyle

A user styles manager for Firefox and Chrome
http://team.firefoxcn.net/#addons
GNU General Public License v3.0
171 stars 13 forks source link

Add-on location permissions? #54

Closed JumpySWE closed 6 years ago

JumpySWE commented 6 years ago

Firefox just notified me that there was an update available for xStyle (3.0.3) but that it required new permissions.

Why does xStyle require location permissions linked to gitee.io?

sylingd commented 6 years ago

gitee.io is a website like GitHub, see here

JumpySWE commented 6 years ago

But why does xStyle require geolocation permissions?

sylingd commented 6 years ago

I don't remember I used that permission. Where did you see it?

JumpySWE commented 6 years ago

When the add-on was updated in Firefox.

Firefox showed a new permissions pop-up for the xStyle (3.0.3) update.

sylingd commented 6 years ago

I have reviewed my code, I haven't change permissions in version 3.0.3 (In addition to the gitee domain name change in this commit), and I haven't write any code about geolocation permissions

JumpySWE commented 6 years ago

Hmm, this is wired then. When I tried installing the 3.0.3 xpi directly, it showed the normal permissions.

But when Firefox automatically updated the add-on it asked for location permissions with a link to gitee.io

Perhaps I misread the pop-up.

I'll double check after the holidays since I won't have access to a computer until then (writing on phone now).

sylingd commented 6 years ago

If you find the reason, please tell me, thank you

JumpySWE commented 6 years ago

It was nothing... Just the Swedish translation of Firefox that made the pop-up a bit confusing to read quickly.