Closed ianb closed 3 months ago
BEM looks good but I find the card__media--loading
selector a bit weird.
We used Suit CSS on addons-frontend which is basically the same thing but you use the component's class name instead Card-media--loading
.
So it would be Base-element--modifier
.
FWIW, no one could intuitively follow the Suit CSS rules on addons-frontend
so we mostly stopped doing it.
It's not 100% clear how we structure class names. We want to use BEM, but we should clarify how that applies to what we're doing. A document also gives us something to discuss as part of its review.