FirefoxUX / photon-components-web

INACTIVE - http://mzl.la/ghe-archive - Photon versions of the some common WebComponents
https://FirefoxUX.github.io/photon-components-web/
Mozilla Public License 2.0
30 stars 11 forks source link

Document BEM convention #17

Closed ianb closed 3 months ago

ianb commented 6 years ago

It's not 100% clear how we structure class names. We want to use BEM, but we should clarify how that applies to what we're doing. A document also gives us something to discuss as part of its review.

mstriemer commented 6 years ago

BEM looks good but I find the card__media--loading selector a bit weird.

We used Suit CSS on addons-frontend which is basically the same thing but you use the component's class name instead Card-media--loading.

So it would be Base-element--modifier.

kumar303 commented 6 years ago

FWIW, no one could intuitively follow the Suit CSS rules on addons-frontend so we mostly stopped doing it.