FirefoxUX / photon-components-web

INACTIVE - http://mzl.la/ghe-archive - Photon versions of the some common WebComponents
https://FirefoxUX.github.io/photon-components-web/
Mozilla Public License 2.0
29 stars 11 forks source link

Build & deploy per pull request #53

Closed lmorchard closed 5 years ago

lmorchard commented 5 years ago

Fixes #42

lmorchard commented 5 years ago

I got this working for PRs on my personal fork. Here's a sample of the comments the script will post on PRs:

https://github.com/lmorchard/photon-components-web/pull/1#issuecomment-434459085

At some point after merge, I should register a new github account specifically for this project, That way, the comments won't all look like I'm posting them. 😖

Also, anyone submitting a PR will get a deployment, so it's not limited to core contributors. I think we could restrict that in the future - e.g. because random PR submitters could cause arbitrary code to be deployed. But, I think it's fairly limited to just one subdirectory on gh-pages, so I'm not too worried