Closed johngruen closed 5 years ago
lmorchard
commented
5 years ago Pull Request: https://FirefoxUX.github.io/photon-components-web/pull/58 Branch: https://FirefoxUX.github.io/photon-components-web/branches/slightly-style-layout Storybook: https://FirefoxUX.github.io/photon-components-web/commits/f79378c2d798733c7b2601366ea1a5349ff3b75b/ Build: https://FirefoxUX.github.io/photon-components-web/commits/f79378c2d798733c7b2601366ea1a5349ff3b75b/dist.zip
lmorchard
commented
5 years ago Pull Request: https://FirefoxUX.github.io/photon-components-web/pull/58 Branch: https://FirefoxUX.github.io/photon-components-web/branches/slightly-style-layout Storybook: https://FirefoxUX.github.io/photon-components-web/commits/1da9409f4562a4ec4cd420185d3e7e231decf1e6/ Build: https://FirefoxUX.github.io/photon-components-web/commits/1da9409f4562a4ec4cd420185d3e7e231decf1e6/dist.zip
lmorchard
commented
5 years ago Rather than explain in comments, I just went ahead and pushed a commit to add a favicon and move the preview styles into a separate CSS file. I think there's a way to change the title without client-side code, but still looking into it.
Edit: Hmm, though it looks like in the static build, the built-in favicon.ico clobbers the one from our static files. Need to keep looking into that too I guess.
lmorchard
commented
5 years ago FWIW, if we really want to, we can make some big changes to things by tweaking or totally rewriting the Webpack config used to run & build storybook.
That includes things all the way down to the .ejs template used to build the HTML via HTMLWebpackPlugin. Might be a bit involved, but we can do it.
johngruen
commented
5 years ago @lmorchard does that count as an R+?
some super minimal layout for storybooks