search

FirefoxUX / photon-components-web

INACTIVE - http://mzl.la/ghe-archive - Photon versions of the some common WebComponents
https://FirefoxUX.github.io/photon-components-web/
Mozilla Public License 2.0
29 stars 11 forks source link

Further Checkbox component refinement #60

Closed lmorchard closed 5 years ago

lmorchard commented 5 years ago

Fixes #59

lmorchard commented 5 years ago

Didn't know about -{moz,webkit}-appearance before now. These changes seem to work for Firefox, Chrome, and Edge on Windows and simplify the markup a bunch.

lmorchard commented 5 years ago

GitHub Pages Deployment

Storybook: https://FirefoxUX.github.io/photon-components-web/commits/6127a39fbcf09223bb6983112b84bb8d1e4c94fd/ Build: https://FirefoxUX.github.io/photon-components-web/commits/6127a39fbcf09223bb6983112b84bb8d1e4c94fd/dist.zip

lmorchard commented 5 years ago

GitHub Pages Deployment

Storybook: https://FirefoxUX.github.io/photon-components-web/commits/3d0625cc0956faaf791538fbe6f87177e4e1c485/ Build: https://FirefoxUX.github.io/photon-components-web/commits/3d0625cc0956faaf791538fbe6f87177e4e1c485/dist.zip

meandavejustice commented 5 years ago

fixed up a merge conflict with the github interface ^^

lmorchard commented 5 years ago

Did another rebase on master and squashed the commits

lmorchard commented 5 years ago

GitHub Pages Deployment

Storybook: https://FirefoxUX.github.io/photon-components-web/commits/bc6ddcd15650820407398110b4dce6108e0bc2b6/ Build: https://FirefoxUX.github.io/photon-components-web/commits/bc6ddcd15650820407398110b4dce6108e0bc2b6/dist.zip

lmorchard commented 5 years ago

GitHub Pages Deployment

Storybook: https://FirefoxUX.github.io/photon-components-web/commits/0df99cb76e1c1d64da54d5dd0db951ccfe0966b5/ Build: https://FirefoxUX.github.io/photon-components-web/commits/0df99cb76e1c1d64da54d5dd0db951ccfe0966b5/dist.zip

lmorchard commented 5 years ago

Pushed tweaks to switch check icons and will file a follow-up issue. Also added some story-specific CSS that expands the checkbox labels to the full width of the containing list items.

I didn't stick that in the CSS for the checkbox component overall, though: I'm not sure if we want to prescribe the width and inline-block display. But, we can move it into there if it's universally useful.