FirefoxUX / photon-components-web

INACTIVE - http://mzl.la/ghe-archive - Photon versions of the some common WebComponents
https://FirefoxUX.github.io/photon-components-web/
Mozilla Public License 2.0
29 stars 11 forks source link

Hacks to use custom HTML template for Storybook #61

Closed lmorchard closed 5 years ago

lmorchard commented 5 years ago
lmorchard commented 5 years ago

GitHub Pages Deployment

Pull Request: https://FirefoxUX.github.io/photon-components-web/pull/61 Branch: https://FirefoxUX.github.io/photon-components-web/branches/use-custom-index-template Storybook: https://FirefoxUX.github.io/photon-components-web/commits/63433ec4691756f2ca587de6cde3d57f8a81ff12/ Build: https://FirefoxUX.github.io/photon-components-web/commits/63433ec4691756f2ca587de6cde3d57f8a81ff12/dist.zip

lmorchard commented 5 years ago

This is kind of ugly, because this part of storybook isn't easy to customize cleanly. But, it should let us specify EJS templates for the HTML.

Right now, there's just one template, but I can tweak this to use different templates for the overall management UI vs the story frame if we need to customize more specifically.

lmorchard commented 5 years ago

There's no particular urgency to this PR - just if it seems useful to have, we can do this. We can also close this and just keep the branch around until/unless we need it.

meandavejustice commented 5 years ago

This looks good to me, I'll merge, but feel free to revert if you feel necessary.