lmorchard
commented
5 years ago note: I started to add a README, but couldn't see any application for it after reading the way the other readmes were used. Let me know if I'm misunderstanding here.
I think we're still kind of figuring out what the READMEs are for. 😞 Could add a stub README with usage doco. But, otherwise, we've got issue #48 to sort out README notions.
I'm also considering adding a background image, to show that the overlay is on top of something. Should it be interactive, and if so what is the firefox way of doing that? I left it since I didn't want to over-complicate it. ex: click on overlay makes it and the popup close and click on 'x' on popup does the same.
We're figuring this stuff out still, too. I'm leaning toward not making these components interactive unless absolutely necessary, so we can stay useful with just HTML & CSS. So far, the React components are mostly just fancy markup templates.
For demonstration purposes, you could add this kind of interactivity to the story, though. I do a bit of this in my PR for Tabs, but I'm still kind of scratching my head whether this is the best way to do.
ericawright
note: I started to add a README, but couldn't see any application for it after reading the way the other readmes were used. Let me know if I'm misunderstanding here.
I'm also considering adding a background image, to show that the overlay is on top of something.
Should it be interactive, and if so what is the firefox way of doing that? I left it since I didn't want to over-complicate it. ex: click on overlay makes it and the popup close and click on 'x' on popup does the same.