FirefoxUX / photon-components-web

INACTIVE - http://mzl.la/ghe-archive - Photon versions of the some common WebComponents

https://FirefoxUX.github.io/photon-components-web/

Mozilla Public License 2.0

29 stars 11 forks source link

Initial Tree implementation #85

Closed lmorchard closed 5 years ago

lmorchard commented 5 years ago

Issue #28

lmorchard commented 5 years ago

Try this again - minimal initial tree implementation, didn't want to try covering the whole draft spec in the first go. I think I fixed a bug that showed up in production build but not dev build.

lmorchard commented 5 years ago

GitHub Pages Deployment

Storybook: https://FirefoxUX.github.io/photon-components-web/commits/eff986f69bb82a03ee8e7c55e2f0205cdc6027a2/ Build: https://FirefoxUX.github.io/photon-components-web/commits/eff986f69bb82a03ee8e7c55e2f0205cdc6027a2/dist.zip

lmorchard commented 5 years ago

Yeah, this is a very handwavy PR just to put a stake in the ground. Probably not a bad idea to stew on it some more, though we could merge it and keep iterating from there. But also.. meh?

The spec kind of confused me as to exactly what we want for this component. There are at least 3 variants and a couple of themes represented there. Do we want all of those in one component with a switch? Separate components? Just apply different style sheets?

bwinton commented 5 years ago

Yeah. And there's the other trees that ntim mentioned in the issue… 🙂

meandavejustice commented 5 years ago

This looks like a reasonable starting point, I say we merge and continue iterating