search

FirefoxUX / photon-icons

The design tokens for the Photon icons
Mozilla Public License 2.0
24 stars 13 forks source link

PDF vector icons for iOS #2

Open garvankeeley opened 6 years ago

garvankeeley commented 6 years ago

PDF icons support is not new in iOS, what is new in iOS 11+ is that a single vector PDF can be used and all needed raster icon sizes will be generated from this. We will be dropping iOS 10 once iOS 12 is released, and at that point we would prefer to use PDF icons. More info: https://ericasadun.com/2017/06/15/the-unexpected-joy-of-vector-images-in-ios-11/

Converting SVG to PDF on OS X doesn't work well with imagemagick convert as I can't find an option to not rasterize, however Inkscape has a command-line mode that works ok: inkscape -z t.svg --export-pdf=t.pdf

bwinton commented 6 years ago

I wonder if we should just store the PDFs in the repo, instead of trying to generate them from SVGs?

@aminalhazwani, @bryanbell? Any opinions on generating/saving PDFs?

aminalhazwani commented 6 years ago

@bwinton as mentioned on Slack maybe with can experiment with the new Figma API for exporting the icons to the different formats so that we could reduce manual work. Currently is not possible to export to PDF but luckily there are people working on it.

The idea would be to have a single Figma file with all the icons, in different sizes - 12, 16, 24 android, 24 iOS and so on - and export them directly to the repository.

What do you think?

aminalhazwani commented 6 years ago

So, today we had a guest at lunch and guess what, he's an engineering at Figma 😅 He told me about how Github created a good system for automatizing the icons distribution, you can read more here https://blog.github.com/2018-04-12-driving-changes-from-designs/

github icons Source

aminalhazwani commented 6 years ago

This is their repo https://github.com/primer/octicons