search

FirefoxUX / photon-icons

The design tokens for the Photon icons
Mozilla Public License 2.0
24 stars 13 forks source link

Sync device list needs a tablet icon #3

Closed garvankeeley closed 5 years ago

garvankeeley commented 6 years ago

There is only mobile phone icon now https://github.com/FirefoxUX/photon-icons/blob/master/icons/desktop/device-mobile-16.svg We should also have a tablet icon. Those are used in sync device lists, and the sync device list message specifies mobile phone and mobile tablet.

garvankeeley commented 6 years ago

x-ref for iOS bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1462113

garvankeeley commented 6 years ago

@ryanfeeley do you know where this is?

bwinton commented 6 years ago

Maybe we should do a diff against the stuff in https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/icons and see where stuff is missing?

garvankeeley commented 6 years ago

For this bug, it is https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/icons/device-tablet.svg

aminalhazwani commented 6 years ago

We have a tablet icon in the /icons website, see https://design.firefox.com/icons/viewer/#device%20tablet, let me add it here as well and double check if anything else is missing

aminalhazwani commented 6 years ago

Ok, the link that I posted up here returns an empty result. We should do an audit of the Photon icons that are on m-c and import them in this repo as @bwinton recommended.