Closed bwinton closed 5 years ago
(Oh, so as an explanation, I've converted all the android icons to use content-fill
, since they don't use svgs anyways, and then I'm generating the light and dark versions of the xml in the build script.)
This looks good. I only left a couple of non-blocking questions. Might be worth it to also get a review from @pocmo!
I wonder if this is needed: As an Android engineer I can either adjust the color in the drawable XML or tint the drawable when loading. It's also possible to use a "color resource" and override the resource in an app (or from an app theme).
I wonder if this is needed: As an Android engineer I can either adjust the color in the drawable XML or tint the drawable when loading. It's also possible to use a "color resource" and override the resource in an app (or from an app theme).
@pocmo Ideally colors should not be manually adjusted. I like the idea of using color resources/themes thou.
Before merging this I would prefer to agree on a solution here https://github.com/mozilla-mobile/android-components/issues/935.
Closing for now, since we should probably do something with tints instead…
We currently don't have android downloads implemented in the icons repo, so when we write that, we can take this into account.
@nt1m, how does this look to you?