search

FirefoxUX / photon-icons

The design tokens for the Photon icons
Mozilla Public License 2.0
22 stars 13 forks source link

Add light and dark android icons. #35

Closed bwinton closed 5 years ago

bwinton commented 6 years ago

We currently don't have android downloads implemented in the icons repo, so when we write that, we can take this into account.

@nt1m, how does this look to you?

bwinton commented 6 years ago

(Oh, so as an explanation, I've converted all the android icons to use content-fill, since they don't use svgs anyways, and then I'm generating the light and dark versions of the xml in the build script.)

pocmo commented 5 years ago

This looks good. I only left a couple of non-blocking questions. Might be worth it to also get a review from @pocmo!

I wonder if this is needed: As an Android engineer I can either adjust the color in the drawable XML or tint the drawable when loading. It's also possible to use a "color resource" and override the resource in an app (or from an app theme).

aminalhazwani commented 5 years ago

I wonder if this is needed: As an Android engineer I can either adjust the color in the drawable XML or tint the drawable when loading. It's also possible to use a "color resource" and override the resource in an app (or from an app theme).

@pocmo Ideally colors should not be manually adjusted. I like the idea of using color resources/themes thou.

aminalhazwani commented 5 years ago

Before merging this I would prefer to agree on a solution here https://github.com/mozilla-mobile/android-components/issues/935.

bwinton commented 5 years ago

Closing for now, since we should probably do something with tints instead…