[update] Add and delete various icons

nt1m commented 5 years ago

Fixes #3 Fixes #30 Fixes #31 Fixes #36

nt1m commented 5 years ago

@bwinton Can you please review this PR ? Thanks!

bwinton commented 5 years ago

Could you run npm run build, to optimize the icons? Aside from that, the code looks fine. @shorlander, @bryanbell, or @brassy- should probably review the style of the icons before we merge…

nt1m commented 5 years ago

@bwinton These are all directly ported from m-c.

Unfortunately, npm run build rips out all the license headers, but I can look at this later today.

nt1m commented 5 years ago

Just to ease-up UX review:

The autoplay icons were introduced in bug 1461656, and I believe @bryanbell created them
The pocket outline icon was introduced in bug 1462790, and was created by @shorlander
The tablet icon was introduced in bug 1383898 and was created by @brampitoyo
The policy engine icons were introduced and bug 1485636 and also were created by Bram
The left sidebar icon is just a flipped version of the right sidebar icon, and it's been introduced in bug 1347543
The cookie icons were introduced in bug 1484312
The cryptomining/fingerprinting icons were introduced in bug 1522567

shorlander commented 5 years ago

Looks good to me. Thank you!

FirefoxUX / photon-icons

[update] Add and delete various icons #49