FirefoxUX / photon

Firefox’s Photon Design System.
https://design.firefox.com/photon/
Mozilla Public License 2.0
273 stars 74 forks source link

Edits to New Capitalization Page #274

Closed MeridelW closed 6 years ago

MeridelW commented 6 years ago

Copy edits and design suggestions for the new capitalization page. New Page: https://firefoxux.github.io/photon-staging/copy/capitalization.html#platform-specific-styles

Requested Edits: https://docs.google.com/document/d/1iHYyO1kCN78uLFcgaU-Xts1ywqNvO4ngWs-pX8eUeFc/edit?usp=sharing

Happy to discuss if needed!

aminalhazwani commented 6 years ago

Hey @MeridelW, we pushed a first update to staging https://firefoxux.github.io/photon-staging/copy/capitalization.html

A couple of considerations and questions:

screen shot 2018-02-20 at 6 03 14 pm
aminalhazwani commented 6 years ago

Hey @MeridelW we pushed new changes to the page https://firefoxux.github.io/photon-staging/copy/capitalization.html. Now the images share all the same height. For the magnifying glass we are going to put it on hold until we figure out a way to apply it everywhere.

The images were the last missing piece for this page. Let us know if anything is missing, we merge to master next Tuesday, February 27th.

MeridelW commented 6 years ago

Hi Amin! Thank you for doing this work. The page is looking good, especially with the images all being the same height. =)

Two notes:

Please keep in mind these are nice-to-have changes that can be saved for another time (and also keep in mind that I don't have a good sense of how long these design changes take!).

On Fri, Feb 23, 2018 at 10:14 AM, Amin Al Hazwani notifications@github.com wrote:

Hey @MeridelW https://github.com/meridelw we pushed new changes to the page https://firefoxux.github.io/photon-staging/copy/capitalization.html. Now the images share all the same height. For the magnifying glass we are going to put it on hold until we figure out a way to apply it everywhere.

The images were the last missing piece for this page. Let us know if anything is missing, we merge to master next Tuesday, February 27th.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/FirefoxUX/photon/issues/274#issuecomment-368055910, or mute the thread https://github.com/notifications/unsubscribe-auth/AgR7ccBdkt8vx8Kht_L_hooC5XVErUO9ks5tXuPWgaJpZM4SGAZm .

aminalhazwani commented 6 years ago

@aminalhazwani reduce the list indentation ☺️