FirefoxUX / photon

Firefox’s Photon Design System.
https://design.firefox.com/photon/
Mozilla Public License 2.0
273 stars 74 forks source link

Request for more purple colors #296

Closed ericawright closed 6 years ago

ericawright commented 6 years ago

I'm combing through the firefox-iOS colors in an attempt to align it more closely to our design system. I'm in need of a lighter purple, something like a Purple40. They are currently using #cf68ff - Purple 50 is too dark, this is displayed on a dark background, and Purple50 is difficult to see.

I'm also in need of something like: #440071, I can get a similar result if I use Purple60 with 30 alpha, but our purples are too red to replace it.

ericawright commented 6 years ago

Also, can we add a Black? For consistency, since we have a white.

aminalhazwani commented 6 years ago

@ericawright sorry if I haven't followed up!

Tomorrow I will go through your purple request, usually the rule of thumb for new shades is to use the same hue and play with the saturation/luminance.

Regarding the black the rationale behind not including it is that we recommend to never user pitch black in UIs but favor Grey 90 instead.

ericawright commented 6 years ago

I understand the rationale, but unfortunately black seems to be a necessary evil. Not including it, for me, just means I have to make my own variable, because I can't avoid it in this case.

aminalhazwani commented 6 years ago

@ericawright if it's only in this case it's reasonable to have an outlier therefore writing your own variable. But now you made me curious, why and where are you forced to use #000000 instead of #0c0c0d?

Regarding the purples the shades that they are suggesting - #cf68ff - is closer to a potential purple 30 rather than purple 40. I tweaked the hue so that it aligns with the rest of the palette and ended to:

I opened https://github.com/FirefoxUX/design-tokens/pull/53.

I'm also in need of something like: #440071, I can get a similar result if I use Purple60 with 30 alpha, but our purples are too red to replace it.

I am not sure I am fully understanding here,#440071 is currently Purple 80. Can you tell me more? Thanks!

ericawright commented 6 years ago

sorry, that was a typo, I meant #7878a5 - almost like a light shade of the ink palette?

As for the black, I suppose you're right - it's hard to change an existing project away from black though.

aminalhazwani commented 6 years ago

sorry, that was a typo, I meant #7878a5 - almost like a light shade of the ink palette?

Gotcha, I'll look into it, thanks for the clarification!

aminalhazwani commented 6 years ago

Gonna move the request about a lighter ink shade to the firefoxux/photon-colors repo.

aminalhazwani commented 6 years ago

See issue https://github.com/FirefoxUX/photon-colors/issues/5