FirefoxUX / photon

Firefox’s Photon Design System.
https://design.firefox.com/photon/
Mozilla Public License 2.0
274 stars 74 forks source link

Colors for dismissable buttons on message bars are not specified #298

Closed rugk closed 6 years ago

rugk commented 6 years ago

This says the dismissable button is a "ghost button, placed in the top right corner" (BTW a link to the ghost buttons may be useful).

So there it does specify the hovered, etc. colors only for grey. I doubt that this is how it should look on a yellow or red message bar.

So how should it actually look? May we even just use the same colors as other buttons? (except that the dismissable button should be transparent when not hovered/in the "default" state.)

rugk commented 6 years ago

Oh, actually I saw it is transparent. Maybe it is supposed to have this light grey tone, okay… In this case, you can just close this issue.

/cc @ENT8R

brassy- commented 6 years ago

@rugk for more info on the button, pls see the button page.