Message-Bar min-height & alignment conflict - Githubissues

FirefoxUX / photon

Firefox’s Photon Design System.

https://design.firefox.com/photon/

Mozilla Public License 2.0

273 stars 74 forks source link

Message-Bar min-height & alignment conflict #328

Open kammueller opened 5 years ago

kammueller commented 5 years ago

Hi, I was trying to implement the new messasge-bar and stumbled across the following difficulties:

the padding of the dismiss-button is not consistent with ghost-buttons. Is that deliberate?
the focus-style of buttons & the dismiss-button is not defined (for regular buttons: shadows)
the min-height does not work at all for a one-liner. The dismiss looks centered but only has a height of 16px + 2*4px padding (= 24px), whereas the container should have 32px. Because the dissmiss button should be at right top, the picture can simply not work out.

How should I solve these problems? Thank you! Matthias