search

FirefoxUX / photon

Firefox’s Photon Design System.
https://design.firefox.com/photon/
Mozilla Public License 2.0
273 stars 74 forks source link

Fix the colors of the generic message bar button #373

Open Rob--W opened 5 years ago

Rob--W commented 5 years ago

The preview at jekyll/images/message-bars/c-gen.svg shows grey buttons (=default button style), which looks reasonable. However, the label in the image and the document's description specified a blue style that is meant to be used for the primary button.

This commit fixes the discrepancy by using the colors of the button as specified _includes/components/buttons/behaviors-default.md , and matches the rendered message bar (c-gen.svg).

TODO: Change "Blue-60" to "Grey-90-a10" at jekyll/images/message-bars/c-gen.svg (I didn't change it here because those letters are a path in the vector image and not easily editable.)

Fixes #287

Rob--W commented 5 years ago

@brassy- https://github.com/FirefoxUX/photon/blob/master/jekyll/images/message-bars/c-gen.svg was introduced in d5c213d6b8e5ba15d4f3f9e360850ed87998ba87, which is authored by you. If you approve of this PR, could you provide an updated SVG where "Blue-60" text is changed to "Grey-90-a10" (which matches the actual color of the button in the SVG)?